Robbie enot
enot commented on pull request MountainTownTechn.../aural_isle#7 2023-10-21 19:29:45 -04:00
WIP: add formatting doc and pre-commit

Any suggestions on a folder to use for things like the pre commit hook?

Also wondering if this commit should format the existing code since it is not currently.

enot pushed to docs-formatting at MountainTownTechn.../aural_isle 2023-10-21 19:28:36 -04:00
136da63d00 Fix typo and add rust market links
acfec3b97e fix pre-commit filename typo
0b0d4cb982 add formatting doc and pre-commit
abe545397b more model refinement
cb3f76aa17 refines MODELS around cart functionality, moves all pricing into Sku model, adds CouponCode model
Compare 5 commits »
enot pushed to docs-formatting at MountainTownTechn.../aural_isle 2023-10-21 19:26:19 -04:00
316b67c596 Fix typo and add rust market links
enot pushed to docs-formatting at MountainTownTechn.../aural_isle 2023-10-21 19:03:34 -04:00
57610d69dc fix pre-commit filename typo
39868563af add formatting doc and pre-commit
Compare 2 commits »
enot commented on pull request MountainTownTechn.../aural_isle#9 2023-10-21 18:48:42 -04:00
WIP: automated-testing

also, are we going to do PR squashes, or should i squash this myself before merge?

I vote squashes, that way we can get a little messy but just squash to merge.

enot commented on issue MountainTownTechn.../aural_isle#6 2023-10-21 14:19:18 -04:00
Code style guide

I like the idea of sharing any hooks we recommend for devs to use in an appropriate folder.

Ya I agree, I was thinking that but wasn't sure the director structure to go with. So the pull…

enot commented on pull request MountainTownTechn.../aural_isle#7 2023-10-21 11:48:13 -04:00
WIP: add formatting doc and pre-commit

Indeed, thank you.

enot pushed to docs-formatting at MountainTownTechn.../aural_isle 2023-10-20 12:01:13 -04:00
cb07f81a1f fix pre-commit filename typo
50ca15d821 add formatting doc and pre-commit
abe545397b more model refinement
cb3f76aa17 refines MODELS around cart functionality, moves all pricing into Sku model, adds CouponCode model
Compare 4 commits »
enot pushed to docs-formatting at MountainTownTechn.../aural_isle 2023-10-19 20:44:14 -04:00
57610d69dc fix pre-commit filename typo
enot created pull request MountainTownTechn.../aural_isle#7 2023-10-19 20:42:25 -04:00
add formatting doc and pre-commit
enot created branch docs-formatting in MountainTownTechn.../aural_isle 2023-10-19 20:40:24 -04:00
enot pushed to docs-formatting at MountainTownTechn.../aural_isle 2023-10-19 20:40:24 -04:00
39868563af add formatting doc and pre-commit
enot commented on issue MountainTownTechn.../aural_isle#6 2023-10-19 20:03:02 -04:00
Code style guide

So cargo fmt --check works as expected and returns non-zero when code is not formatted correctly. It also work recursively through project directories. cargo fmt is using rustfmt and we can…

enot commented on issue MountainTownTechn.../aural_isle#6 2023-10-19 19:23:01 -04:00
Code style guide

Or maybe not, regarding the commit hook. I will test that out tonight and see what happens.

enot commented on issue MountainTownTechn.../aural_isle#6 2023-10-19 19:20:56 -04:00
Code style guide

For Visual Studio Code the rust-analyzer extension has a knob for rustfmt on save and on paste.

Yep, and installing the Rust meta…

enot commented on issue MountainTownTechn.../aural_isle#3 2023-10-19 12:42:07 -04:00
Configure automated testing

We should probably also incorporate #6 as well. This way even if someone doesn't use a formatter in one of our soon to be recommended ways, the code all still ends up with the same style.

enot commented on issue MountainTownTechn.../aural_isle#6 2023-10-19 09:36:03 -04:00
Code style guide

I can do both later today, but unfortunately the day job is calling. So if anyone wants to do it before then, please do.

enot opened issue MountainTownTechn.../aural_isle#6 2023-10-18 20:55:43 -04:00
Code style guide